Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add extend property #1115

Closed
wants to merge 3 commits into from
Closed

feat: Add extend property #1115

wants to merge 3 commits into from

Conversation

Richienb
Copy link
Contributor

@Richienb Richienb commented Oct 15, 2019

Fixes #493

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 9, 2020

Is this intended to be in draft status?

@Richienb
Copy link
Contributor Author

@Gerrit0 Probably not. I made it and forgot it. I'll finish up the PR soon.

src/lib/utils/options/options.ts Outdated Show resolved Hide resolved
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb
Copy link
Contributor Author

@Gerrit0 How should we detect circularity?

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 11, 2020

The simplest way is probably to just keep a Set<string> of the resolved paths that have been loaded, and then error if we see the same path twice. This would technically have some false positives (e.g. extends: ['./a.json', './a.json'], but that's likely a mistake in the first place.

@maneetgoyal
Copy link

Hi @Gerrit0, is this PR awaiting any further corrections?

@Richienb
Copy link
Contributor Author

@maneetgoyal The last thing that needs to be implemented is circularity detection.

@maneetgoyal
Copy link

Hi @Richienb, thanks for picking up this PR. It seems very useful. Any time estimate on this will be of great help.

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb Richienb requested a review from Gerrit0 February 27, 2020 10:04
@Richienb
Copy link
Contributor Author

@maneetgoyal I've just finished the last part of the PR. After a bit of testing, it will be ready.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 27, 2020

Logic looks good to me 👍 I should be able to pull this in this weekend.

@Richienb Richienb marked this pull request as ready for review February 28, 2020 00:39
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 28, 2020

Ah, of course this was built before the options refactor - I'll pull the changes in to the refactored code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support typedoc.json "extends"
3 participants