-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add extend property #1115
Conversation
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Is this intended to be in draft status? |
@Gerrit0 Probably not. I made it and forgot it. I'll finish up the PR soon. |
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Gerrit0 How should we detect circularity? |
The simplest way is probably to just keep a |
Hi @Gerrit0, is this PR awaiting any further corrections? |
@maneetgoyal The last thing that needs to be implemented is circularity detection. |
Hi @Richienb, thanks for picking up this PR. It seems very useful. Any time estimate on this will be of great help. |
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@maneetgoyal I've just finished the last part of the PR. After a bit of testing, it will be ready. |
Logic looks good to me 👍 I should be able to pull this in this weekend. |
Ah, of course this was built before the options refactor - I'll pull the changes in to the refactored code. |
Fixes #493