Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export TypeScript namespaces (or at least ones with enums) #1213

Closed
1 task done
KSXGitHub opened this issue Feb 21, 2020 · 2 comments · Fixed by #1217, dbartholomae/redux-dynamic-modules-beacon#25 or gpicron/ssb-subjective-group#1

Comments

@KSXGitHub
Copy link
Contributor

KSXGitHub commented Feb 21, 2020

Problem

Application#bootstrap requires some enum options. I cannot provide them unless I have access to TypeScript enum objects.

Why is this a problem?

I could have added TypeScript version that TypeDoc uses to my dependency list, but that means that:

  • I have to check for which version TypeDoc uses every time I update TypeDoc.
  • I cannot use TypeScript version I desired.

Suggested Solution

Either:

  • Re-export typescript namespaces: export * as ts from 'typescript'
  • Re-export namespaces from typescript: export { ScriptTarget, ModuleKind } from 'typescript'
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 22, 2020

In 0.17 this will be fixed by TypeScript moving to a peer dependency - #1184.

It seems reasonable to re-export the ts namespace until 0.17 is ready, PR welcome.

KSXGitHub added a commit to KSXGitHub/typedoc that referenced this issue Feb 23, 2020
@KSXGitHub
Copy link
Contributor Author

@Gerrit0 #1217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants