Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readonly tuples were recognized as arrays #1534

Closed
wants to merge 1 commit into from

Conversation

Minhir
Copy link
Contributor

@Minhir Minhir commented Mar 13, 2021

Readonly tuples as method arguments were wrongly recognized as arrays.

So get(arg: readonly [number, string]) was converted to readonly number[]. I fixed it. I hope someone can help to find more elegant way to handle this.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Mar 14, 2021

Thanks for the PR! I think a cleaner fix will to be to resolve the type reference and check the resolved type rather than relying on the internal method to do that.

@Gerrit0 Gerrit0 closed this in 99c6a13 Mar 14, 2021
@Minhir Minhir deleted the readonlyTuple branch March 14, 2021 04:58
This was referenced Mar 14, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants