Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSX indentation wrong after code format #823

Closed
bgrieder opened this issue Jan 27, 2016 · 7 comments
Closed

TSX indentation wrong after code format #823

bgrieder opened this issue Jan 27, 2016 · 7 comments

Comments

@bgrieder
Copy link

The first "wrapping" closing tag is systematically moved to one full ident to the right.
Parent closing tags "follow"

tsx-formatting

atom: 1.4.1
atom-typescript: 8.1.0

@basarat
Copy link
Member

basarat commented Jan 27, 2016

Thanks. Let me update to TypeScript latest.

Once we update to TypeScript latest and it still doesn't work you can create a bug at Microsoft/TypeScript 🌹 (similar to microsoft/TypeScript#3838)

@basarat
Copy link
Member

basarat commented Jan 27, 2016

Planning an update for Friday 🌹

@bgrieder
Copy link
Author

Great. Thanks. Will update Friday and report back/create a bug, as appropriate.

@basarat
Copy link
Member

basarat commented Jan 28, 2016

@bgrieder I made some time and did a release : https://github.com/TypeStrong/atom-typescript/releases/tag/v8.2.0 Because I couldn't keep my hands off readonly :) 🌹

Please raise with MS if formatting doesn't do what you expect and link me in for my knowledge 🌹

@basarat basarat closed this as completed Jan 28, 2016
@bgrieder
Copy link
Author

Many thanks but unfortunately this seemed to have no impact on this issue.
Once thing that bugs me:
We are using tsc 1.7.5.
From #469, I understand atom-typescript is using its own version (ntypescript)
Updating our project to use the nightly of typescript will not help in any way, right ?

@basarat
Copy link
Member

basarat commented Jan 28, 2016

Updating our project to use the nightly of typescript will not help in any way, right ?

Will not help with formatting. Other than that it will allow you to use the latest features in the build server.

@bgrieder
Copy link
Author

OK.
I created issue microsoft/TypeScript#6687
Hope I got the ntypescript version correct

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants