Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoaderOptions: configFileContent #603

Closed
hdennen opened this issue Aug 15, 2017 · 7 comments
Closed

LoaderOptions: configFileContent #603

hdennen opened this issue Aug 15, 2017 · 7 comments
Labels

Comments

@hdennen
Copy link

hdennen commented Aug 15, 2017

We're specifying different tsconfig settings for different builds and I'd like to be able to just generate one and pass it in without writing anything to disk. Is anyone working on anything like this? I'm happy to take a shot at it when I get the time.

@johnnyreilly
Copy link
Member

Not at present but we welcome contributions - go for it!

@hdennen
Copy link
Author

hdennen commented Aug 16, 2017

Will do 👌

@loilo
Copy link
Contributor

loilo commented Aug 25, 2017

We could extend the scope of the possible new configFile option to achieve this (see #607). Naming-wise, it could definitely go in there.

Currently, the option takes file names and path, so strings only. We could passing a JavaScript object interpret as "passing the config directly". What do you think, @hdennen?

I'm not sure if overloading an option like that could confuse users, however it would definitely prevent other kinds of confusion with mutually exclusive options (configFileNameconfigFileContent).

@hdennen
Copy link
Author

hdennen commented Sep 3, 2017

@loilo Honestly I don't think it matters. My knee jerk response is to put options 1 to 1 with what they do but adding more functionality to the configFile option seems fine.

@stale
Copy link

stale bot commented Jan 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

1 similar comment
@stale
Copy link

stale bot commented Mar 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 20, 2019
@stale
Copy link

stale bot commented Mar 27, 2019

Closing as stale. Please reopen if you'd like to work on this further.

@stale stale bot closed this as completed Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants