From 4b0a9b0a90a4768cef5ef68dc689714eba2b1e15 Mon Sep 17 00:00:00 2001
From: mistic100 <contact@git.strangeplanet.fr>
Date: Sat, 12 Nov 2022 21:51:38 +0100
Subject: [PATCH] Fix #2101 support externalSymbolLinkMappings wildcard

---
 CHANGELOG.md                                    |  4 ++++
 internal-docs/third-party-symbols.md            | 14 ++++++++++++++
 src/lib/converter/converter.ts                  |  3 +++
 src/test/behaviorTests.ts                       | 12 ++++++++++++
 src/test/converter2/behavior/externalSymbols.ts |  5 +++++
 5 files changed, 38 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index cfbfa6c1c..ba411de44 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Unreleased
 
+### Features
+
+-   Allow to define wildcard mapping in `externalSymbolLinkMappings`.
+
 ## v0.23.20 (2022-11-03)
 
 ### Bug Fixes
diff --git a/internal-docs/third-party-symbols.md b/internal-docs/third-party-symbols.md
index 04d1cb081..58b0fe354 100644
--- a/internal-docs/third-party-symbols.md
+++ b/internal-docs/third-party-symbols.md
@@ -32,6 +32,20 @@ detected as belonging to the `typescript` package rather than the `global` packa
 }
 ```
 
+A wildcard can be used to provide a fallback link to any unmapped type.
+
+```jsonc
+// typedoc.json
+{
+    "externalSymbolLinkMappings": {
+        "external-lib": {
+            "SomeObject": "https://external-lib.site/docs/SomeObject",
+            "*": "https://external-lib.site/docs"
+        }
+    }
+}
+```
+
 Plugins can add support for linking to third party sites by calling `app.converter.addUnknownSymbolResolver`.
 
 If the given symbol is unknown, or does not appear in the documentation site, the resolver may return `undefined`
diff --git a/src/lib/converter/converter.ts b/src/lib/converter/converter.ts
index cc080e247..cf82d774d 100644
--- a/src/lib/converter/converter.ts
+++ b/src/lib/converter/converter.ts
@@ -190,6 +190,9 @@ export class Converter extends ChildableComponent<
             if (typeof modLinks[name] === "string") {
                 return modLinks[name];
             }
+            if (typeof modLinks["*"] === "string") {
+                return modLinks["*"];
+            }
         });
     }
 
diff --git a/src/test/behaviorTests.ts b/src/test/behaviorTests.ts
index 38d50754f..372b70948 100644
--- a/src/test/behaviorTests.ts
+++ b/src/test/behaviorTests.ts
@@ -225,6 +225,10 @@ export const behaviorTests: {
             typescript: {
                 Promise: "/promise2",
             },
+            "@types/marked": {
+                Lexer: "https://marked.js.org/using_pro#lexer",
+                "*": "https://marked.js.org",
+            },
         });
     },
     externalSymbols(project) {
@@ -238,6 +242,14 @@ export const behaviorTests: {
 
         equal(p.type?.type, "reference" as const);
         equal(p.type.externalUrl, "/promise2");
+
+        const m = query(project, "L");
+        equal(m.type?.type, "reference" as const);
+        equal(m.type.externalUrl, "https://marked.js.org/using_pro#lexer");
+
+        const s = query(project, "S");
+        equal(s.type?.type, "reference" as const);
+        equal(s.type.externalUrl, "https://marked.js.org");
     },
 
     groupTag(project) {
diff --git a/src/test/converter2/behavior/externalSymbols.ts b/src/test/converter2/behavior/externalSymbols.ts
index c16a975d6..f3a7d93c9 100644
--- a/src/test/converter2/behavior/externalSymbols.ts
+++ b/src/test/converter2/behavior/externalSymbols.ts
@@ -1,5 +1,10 @@
+import { Lexer, Slugger } from "marked";
+
 /**
  * Testing custom external link resolution
  * {@link !Promise}
  */
 export type P = Promise<string>;
+
+export const L = new Lexer();
+export const S = new Slugger();