Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Modules displayed as External Modules #124

Closed
FlippieCoetser opened this issue Jul 25, 2015 · 7 comments
Closed

Internal Modules displayed as External Modules #124

FlippieCoetser opened this issue Jul 25, 2015 · 7 comments
Labels
enhancement Improved functionality

Comments

@FlippieCoetser
Copy link
Contributor

Right side navigation lists modules correctly. Main body lists all modules as External modules. See below screen shot.

image

@sebastian-lenz
Copy link
Member

Hi, thank you for your message. Looks like this a naming confusion.

The separation of code belonging to your project ("Internals") and vendor / lib code ("Externals") only appears in the right side navigation and not within the content - this is intentional. You configure this two groups using the --externalPattern option, they are not code related.

Within the left side the caption "External modules" means "CommonJS / AMD modules", the addition "External" was necessary as TypeScript also has "modules" which are basically object literals. These two will be renamed in the near future and will show up as "modules" and "namespaces", see #109.

However I'm not happy with the titles in the right side navigation, maybe we should remove "Internals" altogether and rename "Externals" to something like "Vendors" or "Libs"?

@sebastian-lenz sebastian-lenz added the enhancement Improved functionality label Jul 28, 2015
@aciccarello
Copy link
Collaborator

I like the idea of naming the "Externals" to "Libs"

@evil-shrike
Copy link

I'd suggest using "Dependencies" and remove "internal" (or "Internals") at all - they are not internals they are just the lib.

@balupton
Copy link

Ran into this today, and spent an hour trying different externalPattern combinations to no avail, so I figure that this is the issue.

Is this a theme issue, or a core issue?

@aciccarello
Copy link
Collaborator

aciccarello commented Nov 21, 2018

@balupton Internal/external is a core dis tinction. You may want to look at #903 or the internal-external plugin. You can also ask questions on gitter if that is more helpful.

@balupton
Copy link

balupton commented Nov 21, 2018

From what that plugin says:

Typedoc uses the files: [] array (in tsconfig.json) to determine if code is "Internal". If a file being parsed is in the files: [] array, then the code in that file is "Internal".

Seems like typedoc is ignoring the includes property of tsconfig.json, which should get the same (internal) treatment as the files property.

@aciccarello
Copy link
Collaborator

If you are using a jsconfig.json file TypeDoc will not look at it so you will need to pass those file/directories to typedoc explicitly. Only tsconfig.json files are read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improved functionality
Projects
None yet
Development

No branches or pull requests

6 participants