JSON output missing "sources" node for constructors (HTML source info also incorrect)

[immcintosh]

Search terms

json, sources, constructor

Expected Behavior

I'm reporting this bug specifically due to this issue causing a compatibility issue with sphinx_js documentation generator, and after reviewing what's going on, this does not seems like correct behavior.

The "Constructor" node should include the same "sources" node as a "Function" node does, being that it's a specialized type of function and logically has a source file location. For example, a function node appears as; I would expect the Constructor to have the same source info:

"id": 2,
"name": "default",
"kind": 64,
"kindString": "Function",
"flags": {},
"sources": [
{
	"fileName": "app.tsx",
	"line": 13,
	"character": 12
}

Corollary

The HTML documentation generated for constructors displays an incorrect line number (while functions have correct line numbers).

Actual Behavior

{
	"id": 2,
	"name": "constructor",
	"kind": 512,
	"kindString": "Constructor",
	"flags": {},
	"signatures": [
		{
			"id": 3,
			"name": "new default",
			"kind": 16384,
			"kindString": "Constructor signature",
			"flags": {},
			"type": {
				"type": "reference",
				"id": 1,
				"name": "TestClass"
			}
		}
	]
}

Steps to reproduce the bug

Run typedoc on any file containing a class with a constructor. This problem seems to be universal and I have never seen a constructor node generated with the correct file/line information. For example:

src/test/test.ts

class TestClass {
    public foo() {}
    public bar() {}
    constructor() {}
}

export default TestClass;

tsconfig.json

{
    "compilerOptions": {
        "jsx": "react",
        "allowJs": true,
        "module": "commonjs",
        "skipLibCheck": true,
        "esModuleInterop": true,
        "noImplicitAny": true,
        "sourceMap": true,
        "baseUrl": ".",
        "outDir": "dist",
        "moduleResolution": "node",
        "resolveJsonModule": true,
        "paths": {
            "*": ["node_modules/*"]
        }
    },
    "include": ["src/**/*"],
    "typedocOptions": {
        "entryPoints": ["src/test"],
        "out": "build/typedoc",
        "json": "build/docs.json"
    }
}

Environment

• Typedoc version: 0.21.3
• TypeScript version: 4.3.5
• Node.js version: 15.8.0
• OS: Windows 10

[Gerrit0]

Thanks for the bug report! Yeah... that broke in 0.20. I thought constructorNode.getChildren().find(ts.isConstructorDeclaration) would get the constructor declaration, but that apparently wasn't right.