Function property is mis-interpreted as method

[hez2010]

Search terms

Function property, method

Expected Behavior

interface Foo {
    prop: () => void
}

This should be interpreted as a function property:

"name": "prop",
"kind": 1024,
"kindString": "Property",
"flags": {},
...

Actual Behavior

Instead, typedoc generates a method node for it:

"name": "prop",
"kind": 2048,
"kindString": "Method",
"flags": {},
...

Steps to reproduce the bug

test.ts:

interface Foo {
    prop: () => void
}

tsconfig.json:

{
    "compilerOptions": {
        "target": "es2020"
    }
}

typedoc test.ts --json result.json

Environment

• Typedoc version: 0.21.4
• TypeScript version: 4.4
• Node.js version: v14.17.0
• OS: Windows 11

[Simek]

Refs #1624 (98331b5)

In current project I'm using TypeDoc raw data output. It looks like after the change mentioned above the React/React Native functional components props data has been stripped or moved too.

If I downgrade to 0.21.2 the output is correct again, but there are still comment data missing or misplaced in few cases. The only solution for me right now was a revert to latest version from 0.20 branch.

Environment

• Typedoc version: 0.21.4
• TypeScript version: 4.0.3
• Node.js version: v15.11.0
• OS: macOS 11.5

[Gerrit0]

This should be interpreted as a function property:

From a code generation perspective that targets compiled languages, I can see your point here... however, I'm not sure that this behavior is something that should be reverted. TypeDoc has done the same thing for property-methods for a long time, its detection for these was just improved in a way that broke your use case.

class Foo {
  iAmMethod = (x: string) => parseInt(x)
}

React/React Native functional components props data has been stripped or moved too.

I can't seem to reproduce this, open a new issue with a reproduction to keep different problems separate please.

[tsvetomir]

Just got bitten by this issue after an upgrade. Seems wrong for my particular use case too.

Now the same member will show as a method in the interface and as a property in the implementing class:

interface Foo {
    prop: () => void;

// "kindString": "Method"
}

class FooClass implements Foo {
    prop: () => void;

//  "kindString": "Property",
//  "implementationOf": {
//      "type": "reference",
//      "name": "Foo.prop"
//  }
}

[Gerrit0]

Hmm... that's actually a really good argument for not turning property-methods into methods in type space...

Once TS 4.7 releases, with explicit variance annotations, it won't be necessary to declare intended methods as properties in order to get the correct variance, which should make property-methods less frequent... if the comment plugin is updated so that it can properly inherit comments from property-methods, I think I'm okay with reverting this...