Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme tables render light text against a light background #1684

Closed
jordaaash opened this issue Sep 10, 2021 · 5 comments
Closed

Dark theme tables render light text against a light background #1684

jordaaash opened this issue Sep 10, 2021 · 5 comments
Labels
bug Functionality does not match expectation

Comments

@jordaaash
Copy link

Search terms

theme, dark, table, bug

Expected Behavior

When using the dark theme, or OS theme is dark, tables should be rendered with a dark background so light text is legible.

Actual Behavior

Dark:
Screen Shot 2021-09-10 at 5 18 30 PM

Light:
Screen Shot 2021-09-10 at 5 19 00 PM

Steps to reproduce the bug

Use a Markdown table with Typedoc 0.22 and the dark theme.

Environment

  • Typedoc version: 0.22.1
  • TypeScript version: 4.4.3
  • Node.js version: 14.17.5
  • OS: Mac OS 11.5 Big Sur
@jordaaash jordaaash added the bug Functionality does not match expectation label Sep 10, 2021
@jordaaash
Copy link
Author

Typedoc's own documentation @ https://typedoc.org/api/ is affected by a similar and related issue:

Screen Shot 2021-09-10 at 5 25 05 PM

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Sep 10, 2021

Oh wow that's really bad, thanks for the report!

The codeblock issue is because TypeDoc's site was built with 0.22.0, if you do a refresh there now, it has since been rebuilt with 0.22.1, which fixed codeblocks.

@jordaaash
Copy link
Author

Awesome, thanks!

@DanielRios549
Copy link

How to render a table like this? I see the docs and the help command but I can't figure out how to render a markdown table

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Sep 24, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
None yet
Development

No branches or pull requests

3 participants