Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a link to the home page (index.html in the destination directory) #2085

Closed
MPV65 opened this issue Oct 25, 2022 · 2 comments · Fixed by #2086
Closed

Adding a link to the home page (index.html in the destination directory) #2085

MPV65 opened this issue Oct 25, 2022 · 2 comments · Fixed by #2086
Labels
bug Functionality does not match expectation good first issue Easier issue for first time contributors help wanted Contributions are especially encouraged question Question about functionality

Comments

@MPV65
Copy link

MPV65 commented Oct 25, 2022

Search terms

index.html "home page" link

Question

How does one provide a link to the initial index page that the readme document is rendered on? After navigating away from this, the only way back is via the back button. I have tried adding in a "navigationLinks" field with the value "index.html" but this just gets made relative to module root, so only actually works on the home page.

@MPV65 MPV65 added the question Question about functionality label Oct 25, 2022
@krisztianb
Copy link
Contributor

krisztianb commented Oct 26, 2022

Actually I think there is a bug in the renderer. The name of the project at the very top of the page should IMHO link to the index.html and not to the current page. At least this would be my expected behavior.

Edit: The reason turns out to be an empty href attribute on that link.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Oct 26, 2022

Introduced with #2078, I didn't catch that ?? was used for a string option default when it should have been ||

@Gerrit0 Gerrit0 added bug Functionality does not match expectation help wanted Contributions are especially encouraged good first issue Easier issue for first time contributors labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation good first issue Easier issue for first time contributors help wanted Contributions are especially encouraged question Question about functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants