Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn: Check GDEF mark glyph class doesn't have characters that are not marks. #27

Open
vv-monsalve opened this issue Oct 11, 2024 · 2 comments

Comments

@vv-monsalve
Copy link
Collaborator

@casasin Please revise the listed glyphs to ensure everything is as expected.

⚠️ WARN Check GDEF mark glyph class doesn't have characters that are not marks.

Glyphs in the GDEF mark glyph class become non-spacing and may be repositioned
if they have mark anchors.

Only combining mark glyphs should be in that class. Any non-mark glyph
must not be in that class, in particular spacing glyphs.

Original proposal: fonttools/fontbakery#2877

  • ⚠️ WARN

    The following non-mark characters should not be in the GDEF mark glyph class:
    U+0384, U+0385, U+FBB2, U+FBB3, U+FBB4, U+FBB5, U+FBB6, U+FBB9, U+FBC0, U+FBC2, U+FC5E, U+FC5F, U+FC60, U+FC61, U+FC62, U+FC63, U+FE70, U+FE72, U+FE74, U+FE76, U+FE78, U+FE7A, U+FE7C and U+FE7E


    [code: non-mark-chars]
@josescaglione
Copy link
Collaborator

josescaglione commented Oct 16, 2024

@vv-monsalve
We can disregard this warning (even though we will try to remove it by explicitly marking these as non-mark)

@josescaglione
Copy link
Collaborator

OK, an update after more detailed revision:

  1. The glyphs listed above ARE combining marks
  2. In the glyphs file they are not explicitly set as comb marks but...
  3. they have _anchorname and
  4. they are width 0 on export
  5. and they seem to be correctly in the GDEF mark section

In short, the font is correct and we do not know why FB is flagging these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants