From 621c702ff81f27f64ab4d7076b0c3402567e1585 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu, 3 Oct 2024 20:10:10 -0700 Subject: [PATCH 1/3] Forward integration test exit code to running proc Fixes #5179 --- bin/test_integration.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bin/test_integration.js b/bin/test_integration.js index 936467cc17..00e5b57c24 100644 --- a/bin/test_integration.js +++ b/bin/test_integration.js @@ -62,6 +62,8 @@ async function run() { console.error(run.error); process.exit(run.status ?? -1); } + + process.exit(run.status); } } run(); From 3d9668f8fa2b86bf1d70246158c253372ceb53e1 Mon Sep 17 00:00:00 2001 From: jerch Date: Fri, 4 Oct 2024 15:50:36 +0200 Subject: [PATCH 2/3] fix dispose error in Terminal.test.ts --- test/playwright/Terminal.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/playwright/Terminal.test.ts b/test/playwright/Terminal.test.ts index aea90cdf00..ebc2136a7d 100644 --- a/test/playwright/Terminal.test.ts +++ b/test/playwright/Terminal.test.ts @@ -690,7 +690,7 @@ test.describe('API Integration Tests', () => { window.term = new Terminal(); window.term.dispose(); `); - strictEqual(await ctx.page.evaluate(`window.term._core._isDisposed`), true); + strictEqual(await ctx.page.evaluate(`window.term._core._store._isDisposed`), true); }); test('dispose (opened)', async () => { @@ -702,7 +702,7 @@ test.describe('API Integration Tests', () => { } catch {} } `); - strictEqual(await ctx.page.evaluate(`window.term._core._isDisposed`), true); + strictEqual(await ctx.page.evaluate(`window.term._core._store._isDisposed`), true); }); test('render when visible after hidden', async () => { From 5623ba6b6368392e76bde90400cd31eae0661bfb Mon Sep 17 00:00:00 2001 From: jerch Date: Fri, 4 Oct 2024 16:29:58 +0200 Subject: [PATCH 3/3] slow down web links tests --- addons/addon-web-links/test/WebLinksAddon.test.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/addons/addon-web-links/test/WebLinksAddon.test.ts b/addons/addon-web-links/test/WebLinksAddon.test.ts index 8682c53359..5763044fce 100644 --- a/addons/addon-web-links/test/WebLinksAddon.test.ts +++ b/addons/addon-web-links/test/WebLinksAddon.test.ts @@ -34,7 +34,10 @@ test.describe('WebLinksAddon', () => { test.beforeEach(async () => { await ctx.page.evaluate(` - window.term.reset() + window.term.reset(); + `); + await timeout(50); + await ctx.page.evaluate(` window._linkaddon?.dispose(); window._linkaddon = new WebLinksAddon(); window.term.loadAddon(window._linkaddon);