Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX improvement: update_from_builtin() should automatically promote primitives to composites where possible #147

Closed
pavel-kirienko opened this issue Jan 22, 2021 · 0 comments · Fixed by #197
Closed

UX improvement: update_from_builtin() should automatically promote primitives to composites where possible #147

pavel-kirienko opened this issue Jan 22, 2021 · 0 comments · Fixed by #197
Labels
class-feature help wanted severity-minor

Comments

@pavel-kirienko
Copy link
Member

I have seen similar reports a dozen times: OpenCyphal/yakut#8

The current behavior is not human-friendly because it is so easy to forget the correct nesting sequence when typing out YAML in the command line. The function update_from_builtin() should be modified to automatically promote primitives to composites where such promotion can be done unambiguously:

https://github.com/UAVCAN/pyuavcan/blob/master/pyuavcan/dsdl/_builtin_form.py#L124-L128
pavel-kirienko added a commit that referenced this issue Dec 21, 2021
@pavel-kirienko
Fix #147
64cda78
pavel-kirienko added a commit that referenced this issue Dec 21, 2021
@pavel-kirienko
Fix #147
59421cb
@pavel-kirienko pavel-kirienko linked a pull request Dec 21, 2021 that will close this issue
v1.4 #197
Merged
pavel-kirienko added a commit that referenced this issue Dec 21, 2021
@pavel-kirienko
v1.4 (#197)
28cdd22 
* Refactor the redundant output session to return optimistically, as soon as the first inferior is done transmitting. The test suite currently generates warnings due to some of the async tasks not being finalized properly.

* Fix #147

* Fix doc styling; same problem as in OpenCyphal/pydsdl#74

* Add diagnostics for GNU/Linux test on AppVeyor

* Split transmission in SocketCAN loopback test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
class-feature help wanted severity-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v1.4 OpenCyphal/pycyphal
1 participant
@pavel-kirienko