Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KickoffEnemyPlay: Friendly robot enters enemy half during kickoff causing kickoff violation #3119

Closed
2 tasks
suchirss opened this issue Jan 21, 2024 · 1 comment · Fixed by #3152
Closed
2 tasks
Assignees

Comments

@suchirss
Copy link
Contributor

suchirss commented Jan 21, 2024

Description of the task

When testing KickoffEnemyPlay in kickoff_play_test.py, a friendly robot violates kickoff rules by entering the enemy half. During enemy kickoff, friendly robots are not allowed to enter the enemy half and the center circle. This can be seen through Thunderscope when running kickoff_play_test.py:

KickoffEnemyPlay_fail_cropped

The high level goal is to adjust KickoffEnemyPlay so that our robots stay outside of the enemy half and center circle for the duration of kickoff.

To test this validation, run kickoff_play_test.py (once it is merged) and see if robots stay outside of the enemy half + center circle during enemy kickoff. You can do this through the command: ./tbots.py test //software/ai/hl/stp/play:kickoff_play_test -t

Note that you will have to adjust kickoff_play_test.py to run enemy tests, as this is currently commented out:
image

Acceptance criteria

  • friendly robots do not enter enemy region when running KickoffEnemyPlay
  • kickoff_play_test.py passes tests when is_friendly_test is False

Blocked By

#3123

@suchirss suchirss mentioned this issue Jan 27, 2024
4 tasks
@nimazareian nimazareian self-assigned this Feb 2, 2024
@nimazareian
Copy link
Contributor

My changes should fix this. Though it is also blocked by #3105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants