Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some pairs fail under cath-ssap with PDB_DSSP that work with PDB_DSSP_SEC #49

Open
tonyelewis opened this issue Nov 20, 2017 · 2 comments
Assignees
Labels

Comments

@tonyelewis
Copy link
Contributor

Note that these don't work with --prot-src-files of PDB_DSSP either.

Examples where both proteins have ≥ 30 residues :

1dleB02  2hntE00  142   67  39.85   55   38    7  11.26
2hntE00  4lk4A01   67  125  45.83   44   35    1  10.01
1l1jA01  2hntE00  118   67  35.48   59   50    1  14.44
2hntE00  3gdvC01   67  116  49.33   51   43    7  13.62
2hntE00  3tloA02   67   99  27.21   45   45    1  11.12
3wcyA01  4jqiL02   53   76  51.25   21   27    0   9.71
1hdlA00  4sgbI00   55   51  40.26   27   49    3  11.60
1ktkF02  1smoB00   47  110  57.71   46   41    6   7.62
1ktkF02  2dm3A00   47  110  42.51   26   23    0   4.93
1ktkF02  3irzA03   47   99  46.07   42   42    6   6.73
2hntE00  4fvdA01   67   42  52.51   32   47    7  10.35
3tbxB00  3wcyA01   41   53  57.29   26   49    2   8.93
2zuxA01  3tvmE02   88   32  55.38   30   34   12   4.95
1dx5I02  1yukB02   33   31  70.54   18   54   12   5.90
@tonyelewis tonyelewis added the bug label Nov 20, 2017
@tonyelewis tonyelewis self-assigned this Nov 20, 2017
@tonyelewis tonyelewis changed the title Some cath-ssaps work with --prot-src-files of PDB_DSSP but not PDB Some pairs fail under cath-ssap that work with SSAP Nov 20, 2017
@tonyelewis
Copy link
Contributor Author

To be more precise... these all work under PDB_DSSP_SEC, eg:

cath-ssap --prot-src-files PDB_DSSP_SEC 1dleB02 2hntE00

...but fail under PDB_DSSP, eg:

cath-ssap --prot-src-files PDB_DSSP     1dleB02 2hntE00

I will change the title accordingly.

@tonyelewis tonyelewis changed the title Some pairs fail under cath-ssap that work with SSAP Some pairs fail under cath-ssap with PDB_DSSP that work with PDB_DSSP_SEC Dec 15, 2017
@tonyelewis
Copy link
Contributor Author

I've looked a little bit into 1dx5I02 versus 1yukB02 and found that:

  • the reason it works under PDB_DSSP_SEC is that it's doing a fast_ssap; the following slow_ssap it does fails.
  • the reason it fails under PDB_DSSP is because it doesn't do a fast_ssap because it deduces that there aren't any secondary structures in 1dx5I02
  • whereas prosec has assigned five beta-strand secondary structures: residues with indices (offset 1) 5-8, 8-11, 17-20, 25-28, 30-33, which correspond to residues 394-397, 397-400, 406-409, 414-417, 419-422
  • each of those stretches covers four residues in which prosec has assigned beta-strands to the middle two.

So this could probably fixed by more work to improve the code's ability to replicate the behaviour in prosec / secmake. That should be done with (a) test-cases to demonstrate the specific improvement (b) the use of large-scale comparisons to ensure that specific changes are reducing overall errors, not increasing them.

But it's also worth noting that all the versions are failing to achieve anything in the slow ssap here and that's probably the more significant problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant