-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyLint #164
Comments
Would this allow us to remove runtime type checking assertions? |
Maybe? Linting should help typecheck any parameters that get passed in, but wouldn't necessarily help if we change the datatype in the function (ie. dictionary --> DataFrame). |
Why would we want to remove runtime type checking? |
For the same reason we don't check if something is a number in Java. Static type checkers remove the possibility of using a string instead of a number, as an example (so runtime guards don't make sense). Admittedly it would be useful in cases where types don't cover (ie: this value should be greater than 0). We could also use pydantic to still have runtime guards without checking ourselves. |
Add linting, similar to the setup here: https://github.com/UCSD-E4E/acoustic-multiclass-training/blob/main/.github/workflows/pylint.yml
This should also include some restructuring to remove old/irrelevant functions
The text was updated successfully, but these errors were encountered: