Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(EMS-895): no PDF - CRON - Abandoned application access #2433

Merged
merged 7 commits into from
May 24, 2024
Merged

feat(EMS-895): no PDF - CRON - Abandoned application access #2433

merged 7 commits into from
May 24, 2024

Conversation

Zainzzkk
Copy link
Collaborator

@Zainzzkk Zainzzkk commented May 21, 2024 •
edited by ttbarnes
Loading

Introduction ✏️

This PR prevents access to an abandoned application, including in the dashboard.

Resolution ✔️

  • Updated UI graphql query to filter out Abandoned applications
  • Updated API to create and update an abandoned application
  • Split up createAnApplication to use a helper to create the application
  • Added createAnAbandonedApplication to allowed dev resolvers
  • Added new e2e function and api call for creating abandoned application
  • Added test for access to an abandoned application

Miscellaneous ➕

  • Updated ui eslintrc.js
  • Lint fixes

@Zainzzkk Zainzzkk added the feature New functionality label May 21, 2024
@Zainzzkk Zainzzkk self-assigned this May 21, 2024
ttbarnes
ttbarnes approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@ttbarnes ttbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@Zainzzkk Zainzzkk merged commit a67483c into main-application-no-pdf May 24, 2024
152 checks passed
@Zainzzkk Zainzzkk deleted the feat/EMS-895 branch May 24, 2024 15:23
@abhi-markan abhi-markan mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttbarnes ttbarnes ttbarnes approved these changes

Assignees

@Zainzzkk Zainzzkk

Labels
chore Chore feature New functionality tech Technical debt/improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zainzzkk @ttbarnes