Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(EMS-3063): no PDF - Your business - Turnover - Dynamic legend #2467

Merged
merged 6 commits into from
May 23, 2024
Merged

feat(EMS-3063): no PDF - Your business - Turnover - Dynamic legend #2467

merged 6 commits into from
May 23, 2024

Conversation

Zainzzkk
Copy link
Collaborator

Introduction ✏️

This PR adds a dynamic legend including the currency on the turnover page

Resolution ✔️

  • Added TURNOVER_LEGEND to pageVariables to dynamically construct legend
  • Changed from supportedCurrencies to allCurrencies
  • Updated tests

Miscellaneous ➕

  • Updated assertHeadingWithCurrencyName to test selector

@Zainzzkk Zainzzkk added the feature New functionality label May 23, 2024
@Zainzzkk Zainzzkk self-assigned this May 23, 2024
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa May 23, 2024 15:08 — with GitHub Actions Abandoned
@ttbarnes ttbarnes merged commit 2ef84f3 into main-application-no-pdf May 23, 2024
152 checks passed
@ttbarnes ttbarnes deleted the feat/EMS-3063 branch May 23, 2024 16:02
@abhi-markan abhi-markan mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttbarnes ttbarnes ttbarnes approved these changes

Assignees

@Zainzzkk Zainzzkk

Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zainzzkk @ttbarnes