Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EMS-3348-3402): no PDF - check your answers - export contract - submit button #2502

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

ttbarnes
Copy link
Contributor

Introduction ✏️

This PR fixes an issue where an unnecessary "save and back" button was rendering in the "Check your answers - export contract" page.

Resolution ✔️

  • Remove unused EXPORT_CONTRACT_SAVE_AND_BACK UI route.
  • Update E2E test.
  • Update the GET controller's pageVariables to return a SUBMIT_BUTTON_COPY property instead of SAVE_AND_BACK_URL
    • Note: the submit button should have "save and back".
    • This is unique compared to all other "save and back" buttons, where they require a "save and back" URL.
    • This form now only has 1 button and is at the end of the "prepare application" section/journey.
  • Update nunjucks template.

@ttbarnes ttbarnes added bug Something isn't working tech Technical debt/improvements fix Fixes an existing issue labels May 31, 2024
@ttbarnes ttbarnes self-assigned this May 31, 2024
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 1, 2024 09:39 — with GitHub Actions Abandoned
@ttbarnes ttbarnes merged commit 7011ab9 into main-application-no-pdf Jun 4, 2024
152 checks passed
@ttbarnes ttbarnes deleted the fix/EMS-3348-3402 branch June 4, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix Fixes an existing issue tech Technical debt/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants