Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EMS-3466): no pdf - application submission - XLSX - your buyer section #2554

Merged
merged 7 commits into from
Jun 11, 2024

Conversation

ttbarnes
Copy link
Contributor

Introduction ✏️

This PR fixes an issue in the "your buyer" section of the XLSX, where the "has previous credit insurance cover with buyer" field would render even if the question/answer has not been answered.

This field should only render if the total contract value of an application is over the threshold.

Resolution ✔️

  • Update XLSX_ROW_INDEXES to:
    • Not increment the DECLARATIONS title if the exporter is connected with the buyer.
    • Increment if the total contract value is over the threshold.
  • Update unit tests.
  • Update the mapBuyer function.
  • Update mapPreviousCoverWithBuyer to only return XLSX rows if the total contract value is over the threshold.

@ttbarnes ttbarnes added bug Something isn't working fix Fixes an existing issue labels Jun 11, 2024
@ttbarnes ttbarnes self-assigned this Jun 11, 2024
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:18 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:18 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:18 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:18 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:18 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:18 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:18 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa June 11, 2024 10:19 — with GitHub Actions Abandoned
@ttbarnes ttbarnes merged commit 3750ce1 into main-application-no-pdf Jun 11, 2024
166 checks passed
@ttbarnes ttbarnes deleted the fix/EMS-3466 branch June 11, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix Fixes an existing issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants