Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EMS-3342): no pdf - application submission - XLSX - loss payee - financial information #2562

Merged
merged 13 commits into from
Jun 12, 2024

Conversation

ttbarnes
Copy link
Contributor

@ttbarnes ttbarnes commented Jun 11, 2024

Introduction ✏️

This PR updates the policy section of the XLSX to include decrypted financial details, also includes some date formatting tweaks.

Resolution ✔️

  • Create new ABBREVIATED policy type constants.
  • Update getPopulatedApplication helper function to have object structured params and accept decryptFinancialUk decryptFinancialInternational params.
  • Update submitApplication GraphQL resolver to call getPopulatedApplication with decryption params.
  • Update the POLICY_TYPE XLSX row to map the policy type via a new mapping function, mapPolicyType.
  • Update policy XLSX row value's date format.
  • Create new createABroker helper function.
  • Update createALossPayeeFinancialInternational and createALossPayeeFinancialUk helper functions to return the vector object.
  • Create new getNominatedLossPayee helper function.
  • Update getPopulatedApplication to have an module structure.
  • Update getPopulatedApplication to call getNominatedLossPayee with conditional decryption params.
  • Update getApplicationByReferenceNumber GraphQL query to call getPopulatedApplication, which now handles decryption, instead of manually calling decryption functions.
  • Update createFullApplication test helper function to create/connect a broker and remove now unnecessary nominated loss payee logic.
  • Update createLossPayeeFinancialDetailsInternational test helper function to create and connect a vector.
  • Update createLossPayeeFinancialDetailsUk test helper function to create and connect a vector.
  • Create new createNominatedLossPayee test helper function.

Miscellaneous ➕

  • Minor logging improvements.
  • Minor unit test application variable naming improvements.
  • Minor documentation improvements.

@ttbarnes ttbarnes added enhancement New feature or request tech Technical debt/improvements chore Chore labels Jun 11, 2024
@ttbarnes ttbarnes self-assigned this Jun 11, 2024
@ttbarnes ttbarnes merged commit 4c1d9fd into main-application-no-pdf Jun 12, 2024
166 checks passed
@ttbarnes ttbarnes deleted the feat/EMS-3342-lossPayee branch June 12, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore documentation Improvements or additions to documentation enhancement New feature or request tech Technical debt/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants