-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(EMS-3342): no pdf - application submission - XLSX - loss payee - financial information #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttbarnes
added
enhancement
New feature or request
tech
Technical debt/improvements
chore
Chore
labels
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Chore
documentation
Improvements or additions to documentation
enhancement
New feature or request
tech
Technical debt/improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
This PR updates the policy section of the XLSX to include decrypted financial details, also includes some date formatting tweaks.
Resolution ✔️
ABBREVIATED
policy type constants.getPopulatedApplication
helper function to have object structured params and acceptdecryptFinancialUk
decryptFinancialInternational
params.submitApplication
GraphQL resolver to callgetPopulatedApplication
with decryption params.POLICY_TYPE
XLSX row to map the policy type via a new mapping function,mapPolicyType
.createABroker
helper function.createALossPayeeFinancialInternational
andcreateALossPayeeFinancialUk
helper functions to return thevector
object.getNominatedLossPayee
helper function.getPopulatedApplication
to have an module structure.getPopulatedApplication
to callgetNominatedLossPayee
with conditional decryption params.getApplicationByReferenceNumber
GraphQL query to callgetPopulatedApplication
, which now handles decryption, instead of manually calling decryption functions.createFullApplication
test helper function to create/connect a broker and remove now unnecessary nominated loss payee logic.createLossPayeeFinancialDetailsInternational
test helper function to create and connect a vector.createLossPayeeFinancialDetailsUk
test helper function to create and connect a vector.createNominatedLossPayee
test helper function.Miscellaneous ➕