Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EMS-3454): no PDF - XLSX - Currency symbols #2605

Merged
merged 9 commits into from
Jun 21, 2024

Conversation

Zainzzkk
Copy link
Collaborator

@Zainzzkk Zainzzkk commented Jun 19, 2024

Introduction ✏️

Many currency symbols were being displayed as GBP In XLSX when an alternative currency selected.

Resolution ✔️

  • Used section's CURRENCY_CODE in formatCurrency
  • Updated tests

@Zainzzkk Zainzzkk added the fix Fixes an existing issue label Jun 19, 2024
@Zainzzkk Zainzzkk self-assigned this Jun 19, 2024
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 20, 2024 12:24 — with GitHub Actions Abandoned
@ttbarnes ttbarnes merged commit cf59647 into main-application-no-pdf Jun 21, 2024
167 checks passed
@ttbarnes ttbarnes deleted the fix/EMS-3454 branch June 21, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes an existing issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants