Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(EMS-2433): no PDF - Eligibility - No short term cover redirect #2621

Merged
merged 10 commits into from
Jul 2, 2024
Merged

feat(EMS-2433): no PDF - Eligibility - No short term cover redirect #2621

merged 10 commits into from
Jul 2, 2024

Conversation

Zainzzkk
Copy link
Collaborator

@Zainzzkk Zainzzkk commented Jun 21, 2024 •
edited by ttbarnes
Loading

Introduction ✏️

This PR adds a redirect for when noShortTermCover is available for the buyer country but insuranceSupport is available

Resolution ✔️

  • Added logic to check if noShortTermCover and if noinsuranceSupport, then to redirect to CONTRACT_TOO_SHORT page
  • Updated canApplyForInsuranceOnline to take boolean with shortTermCover
  • Removed mapping for applying offline
  • Removed all instances of canApplyForInsuranceOffline
  • Removed redirect to APPLY_OFFLINE from buyer country controller
  • Updated tests
  • Added e2e tests for unsupported and contract too short countries
  • Remove now irrelevant "cannot apply offline" exit page

@Zainzzkk Zainzzkk added the feature New functionality label Jun 21, 2024
@Zainzzkk Zainzzkk self-assigned this Jun 21, 2024
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 13:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes merged commit 1753a3a into main-application-no-pdf Jul 2, 2024
168 checks passed
@ttbarnes ttbarnes deleted the feat/EMS-2433 branch July 2, 2024 15:41
@abhi-markan abhi-markan mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttbarnes ttbarnes ttbarnes approved these changes

Assignees

@Zainzzkk Zainzzkk

Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zainzzkk @ttbarnes