Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(EMS-3471): no PDF - Account - Incorrect resend confirmation email url #2633

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix(EMS-3471): no PDF - Account - Incorrect resend confirmation email url #2633

merged 1 commit into from
Jun 25, 2024

Conversation

Zainzzkk
Copy link
Collaborator

@Zainzzkk Zainzzkk commented Jun 25, 2024 •
edited by ttbarnes
Loading

Introduction ✏️

This PR fixes an issue where the resend confirmation email had 2 https's

Resolution ✔️

  • Removed extra https from urlOrigin
  • Updated test

@Zainzzkk Zainzzkk added the fix Fixes an existing issue label Jun 25, 2024
@Zainzzkk Zainzzkk self-assigned this Jun 25, 2024
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:05 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:06 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:06 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:06 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:06 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:06 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 25, 2024 09:06 — with GitHub Actions Abandoned
ttbarnes
ttbarnes approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@ttbarnes ttbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@ttbarnes ttbarnes merged commit 1e4d6ea into main-application-no-pdf Jun 25, 2024
167 checks passed
@ttbarnes ttbarnes deleted the fix/EMS-3471 branch June 25, 2024 12:40
@abhi-markan abhi-markan mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttbarnes ttbarnes ttbarnes approved these changes

Assignees

@Zainzzkk Zainzzkk

Labels
fix Fixes an existing issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zainzzkk @ttbarnes