Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(EMS-3515): no PDF - XLSX - Policy - Pre credit period #2636

Merged
merged 3 commits into from
Jun 26, 2024
Merged

fix(EMS-3515): no PDF - XLSX - Policy - Pre credit period #2636

merged 3 commits into from
Jun 26, 2024

Conversation

Zainzzkk
Copy link
Collaborator

@Zainzzkk Zainzzkk commented Jun 25, 2024 •
edited by ttbarnes
Loading

Introduction ✏️

This PR adds a missing row for credit period in the "policy" section of the XLSX sent during application submission.

Resolution ✔️

  • Added row for when NEED_PRE_CREDIT_PERIOD is true
  • Modified indexes
  • Added tests

@Zainzzkk Zainzzkk added the fix Fixes an existing issue label Jun 25, 2024
@Zainzzkk Zainzzkk self-assigned this Jun 25, 2024
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:49 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:49 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:49 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:49 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:49 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:49 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:49 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:49 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:49 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:49 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:49 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:49 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:50 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:50 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:50 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:50 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:50 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:50 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:50 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:50 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:50 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:50 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:50 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 26, 2024 13:50 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk merged commit 1bd056e into main-application-no-pdf Jun 26, 2024
167 checks passed
@Zainzzkk Zainzzkk deleted the fix/EMS-3515 branch June 26, 2024 13:59
@abhi-markan abhi-markan mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttbarnes ttbarnes ttbarnes approved these changes

Assignees

@Zainzzkk Zainzzkk

Labels
fix Fixes an existing issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zainzzkk @ttbarnes