Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EMS-3520): no pdf - dashboard - policy currency code #2641

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

ttbarnes
Copy link
Contributor

Introduction ✏️

This PR fixes an issue in the dashboard where the "value" column always render with a GBP currency code, when it should use the currency selected when completing the policy section.

Resolution ✔️

  • Update some cypress commands to consume and pass a chooseCurrency param.
  • Add a new E2E test.
  • Update "get applications" GQL query to return the policy currency code.
  • Update mapValue to use the policy currency code. Otherwise, default to GBP.

@ttbarnes ttbarnes added bug Something isn't working chore Chore fix Fixes an existing issue labels Jun 25, 2024
@ttbarnes ttbarnes self-assigned this Jun 25, 2024
@ttbarnes ttbarnes merged commit 44a1f60 into main-application-no-pdf Jun 26, 2024
167 checks passed
@ttbarnes ttbarnes deleted the fix/EMS-3520 branch June 26, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Chore fix Fixes an existing issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants