Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EMS-3518): no pdf - application submission - XLSX - final destination #2642

Merged
merged 13 commits into from
Jun 26, 2024

Conversation

ttbarnes
Copy link
Contributor

@ttbarnes ttbarnes commented Jun 26, 2024

Introduction ✏️

This PR fixes an issue where, if the "final destination known" question is answered as "yes", the final destination country would not render in the "export contract" section of the XLSX.

Resolution ✔️

  • Update E2E finalDestinationKnown params to default to false.
  • Update various E2E commands to consume and pass a finalDestinationKnown param.
  • Update XLSX_ROW_INDEXES to conditionally increment indexes.TITLES.DECLARATIONS if finalDestinationKnown is true.
  • Create a new mapFinalDestination XLSX mapping function.

Miscellaneous ➕

  • Add E2E tests for submitting an application as a single or multiple policy type with a fully populated "business" section.

@ttbarnes ttbarnes added bug Something isn't working tech Technical debt/improvements chore Chore fix Fixes an existing issue labels Jun 26, 2024
@ttbarnes ttbarnes self-assigned this Jun 26, 2024
@ttbarnes ttbarnes merged commit 6123d86 into main-application-no-pdf Jun 26, 2024
167 checks passed
@ttbarnes ttbarnes deleted the fix/EMS-3518 branch June 26, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Chore fix Fixes an existing issue tech Technical debt/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants