Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EMS-3508): no pdf - application submission - XLSX - buyer conditions #2647

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

ttbarnes
Copy link
Contributor

Introduction ✏️

This PR fixes an issue with the XLSX where the formatting index for the "declarations" title be incorrect due to a missing buyer condition.

Resolution ✔️

  • Update XLSX_ROW_INDEXES to:
    • Increment 2x titles if exporterIsConnectedWithBuyer is true.
    • Increment 2x titles if totalContractValueOverThreshold and exporterHasPreviousCreditInsuranceWithBuyer are true.
    • Increment AGENT_ADDRESS if totalContractValueOverThreshold` is true.
  • Update API test mocks.

Miscellaneous ➕

  • Add E2E tests for submitting an application (single and multiple contracts) with minimal buyer conditions.

@ttbarnes ttbarnes added bug Something isn't working chore Chore fix Fixes an existing issue labels Jun 27, 2024
@ttbarnes ttbarnes self-assigned this Jun 27, 2024
@ttbarnes ttbarnes merged commit 1c69898 into main-application-no-pdf Jun 27, 2024
166 of 167 checks passed
@ttbarnes ttbarnes deleted the fix/EMS-3508 branch June 27, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Chore fix Fixes an existing issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants