Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(EMS-3530): no PDF - Pure number in text field #2673

Merged
merged 4 commits into from
Jul 4, 2024
Merged

fix(EMS-3530): no PDF - Pure number in text field #2673

merged 4 commits into from
Jul 4, 2024

Conversation

Zainzzkk
Copy link
Collaborator

@Zainzzkk Zainzzkk commented Jul 3, 2024

Introduction ✏️

This PR fixes an issue where a pure number in a text field goes to problem with service page

Resolution ✔️

  • Added fields to STRING_NUMBER_FIELDS in sanitise-value
  • Updated tests
  • Added e2e test to test fields

Miscellaneous ➕

  • Fixed sonarcloud issue in send-email-application-submission-deadline

@Zainzzkk Zainzzkk added the fix Fixes an existing issue label Jul 3, 2024
@Zainzzkk Zainzzkk self-assigned this Jul 3, 2024
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 3, 2024 15:51 — with GitHub Actions Abandoned
ttbarnes
ttbarnes approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@ttbarnes ttbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@ttbarnes ttbarnes merged commit adaea21 into main-application-no-pdf Jul 4, 2024
169 checks passed
@ttbarnes ttbarnes deleted the fix/EMS-3530 branch July 4, 2024 15:34
@abhi-markan abhi-markan mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttbarnes ttbarnes ttbarnes approved these changes

Assignees

@Zainzzkk Zainzzkk

Labels
fix Fixes an existing issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zainzzkk @ttbarnes