Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(EMS-3508-3543): no pdf - application submission - XLSX - agent values #2675

Merged
merged 5 commits into from
Jul 3, 2024
Merged

fix(EMS-3508-3543): no pdf - application submission - XLSX - agent values #2675

merged 5 commits into from
Jul 3, 2024

Conversation

ttbarnes
Copy link
Contributor

@ttbarnes ttbarnes commented Jul 3, 2024

Introduction ✏️

This PR fixes 2x issues in the XLSX where:

  • The "Agent country" field was rendering a country code instead of the country name.
  • The "Agent charge amount" field was not rendering a currency code.

Resolution ✔️

  • Update mapAgentChargeAmount to:
    • Consume a list of countries
    • Call getCountryByIsoCode.
    • Call formatCurrency with FIXED_SUM_AMOUNT as a number (it's saved as a string).

Miscellaneous ➕

  • Various application submission E2E test improvements.

@ttbarnes ttbarnes added bug Something isn't working tech Technical debt/improvements chore Chore fix Fixes an existing issue labels Jul 3, 2024
@ttbarnes ttbarnes self-assigned this Jul 3, 2024
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 3, 2024 16:09 — with GitHub Actions Abandoned
@ttbarnes ttbarnes merged commit 3e15309 into main-application-no-pdf Jul 3, 2024
168 checks passed
@ttbarnes ttbarnes deleted the fix/EMS-3508-3543 branch July 3, 2024 16:43
@abhi-markan abhi-markan mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zainzzkk Zainzzkk Zainzzkk approved these changes

Assignees

@ttbarnes ttbarnes

Labels
bug Something isn't working chore Chore fix Fixes an existing issue tech Technical debt/improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttbarnes @Zainzzkk