Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iac): code improvement #250

Merged
merged 4 commits into from
Jun 16, 2023
Merged

fix(iac): code improvement #250

merged 4 commits into from
Jun 16, 2023

Conversation

abhi-markan
Copy link
Contributor

Introduction

IaC Production environment code improvement.

Resolution

  • Changed prod to production to adhere with improved naming conventions.
  • Multiple AZ cli login for respective scopes.
  • Improved VNET peer naming convention to cater for multiple environments.

@abhi-markan abhi-markan added the Infrastructure Infrastructure or IaC label Jun 16, 2023
@abhi-markan abhi-markan self-assigned this Jun 16, 2023
@abhi-markan abhi-markan temporarily deployed to qa June 16, 2023 12:17 — with GitHub Actions Inactive
@abhi-markan abhi-markan temporarily deployed to qa June 16, 2023 12:17 — with GitHub Actions Inactive
@abhi-markan abhi-markan temporarily deployed to qa June 16, 2023 12:17 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

avaitonis
avaitonis approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@avaitonis avaitonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhi-markan abhi-markan merged commit 5f7b1df into main Jun 16, 2023
@abhi-markan abhi-markan deleted the fix/iac branch June 16, 2023 13:47
@github-actions github-actions bot mentioned this pull request Jun 16, 2023
Merged
abhi-markan pushed a commit that referenced this pull request Jul 3, 2023
@github-actions
chore(main): release 1.14.0 (#209)
416cd2c 
🤖 I have created a release *beep* *boop*
---


##
[1.14.0](v1.13.0...v1.14.0)
(2023-07-03)


### Features

* **APIM-261:** API import post deployment
([#210](#210))
([670f5f9](670f5f9))
* **APIM-261:** individual database hosts
([#207](#207))
([38e9e9e](38e9e9e))


### Bug Fixes

* **APIM-207:** Iac Monitor
([#218](#218))
([e43bf3f](e43bf3f))
* **deployment:** api import
([#237](#237))
([5ffc5e3](5ffc5e3))
* **deps:** update all
([#251](#251))
([0ceeb63](0ceeb63))
* **deps:** update all
([#266](#266))
([a7586f9](a7586f9))
* **deps:** update dependency @nestjs/config to v2.3.4
([#239](#239))
([49417b2](49417b2))
* **deps:** update dependency @nestjs/config to v3
([#241](#241))
([54b776f](54b776f))
* **deps:** update dependency @nestjs/swagger to v7
([#249](#249))
([9d1c5ef](9d1c5ef))
* **deps:** update dependency @nestjs/swagger to v7.0.12
([#274](#274))
([062eb78](062eb78))
* **deps:** update dependency @nestjs/swagger to v7.0.3
([#258](#258))
([749de27](749de27))
* **deps:** update dependency @nestjs/swagger to v7.0.4
([#260](#260))
([32b755f](32b755f))
* **deps:** update dependency @nestjs/typeorm to v10
([#242](#242))
([90198d1](90198d1))
* **deps:** update dependency dotenv to v16.2.0
([#245](#245))
([21fbf68](21fbf68))
* **deps:** update dependency nestjs-pino to v3.3.0
([#244](#244))
([50e8021](50e8021))
* **deps:** update dependency typeorm to v0.3.17
([#256](#256))
([f50c492](f50c492))
* **deps:** update nest monorepo to v10 (major)
([#243](#243))
([248cbed](248cbed))
* **deps:** update nest monorepo to v10.0.4
([#275](#275))
([5cd06c6](5cd06c6))
* **deps:** update nest monorepo to v10.0.5
([#279](#279))
([17f0172](17f0172))
* **iac:** added custom dns for vnet
([#262](#262))
([927057a](927057a))
* **iac:** code improvement
([#250](#250))
([5f7b1df](5f7b1df))
* **iac:** deployment
([#238](#238))
([b24ed3b](b24ed3b))
* **iac:** deployment improvement
([#255](#255))
([a54914a](a54914a))
* **remove-env:** removed API_KEY_STRATEGY env variable
([#229](#229))
([804aacf](804aacf))


### Documentation

* **cicd:** updated documentation + deps bump
([#220](#220))
([441c570](441c570))


### Miscellaneous

* **deps-dev:** Bump @commitlint/cli from 17.6.3 to 17.6.5
([#217](#217))
([dda7e48](dda7e48))
* **deps-dev:** Bump @commitlint/config-conventional from 17.6.3 to
17.6.5 ([#212](#212))
([873b265](873b265))
* **deps-dev:** Bump @tsconfig/node20 from 1.0.1 to 1.0.2
([#270](#270))
([bf5f19a](bf5f19a))
* **deps-dev:** Bump @types/node from 20.2.3 to 20.2.4
([#208](#208))
([0437bbc](0437bbc))
* **deps-dev:** Bump @types/node from 20.2.4 to 20.2.5
([#211](#211))
([e008785](e008785))
* **deps-dev:** Bump @types/node from 20.2.5 to 20.3.0
([#230](#230))
([d404798](d404798))
* **deps-dev:** Bump @typescript-eslint/eslint-plugin from 5.59.7 to
5.59.8 ([#215](#215))
([1ab90c4](1ab90c4))
* **deps-dev:** Bump @typescript-eslint/eslint-plugin from 5.59.8 to
5.59.9 ([#227](#227))
([61d28cc](61d28cc))
* **deps-dev:** Bump @typescript-eslint/parser from 5.59.7 to 5.59.8
([#214](#214))
([f1ade01](f1ade01))
* **deps-dev:** Bump @typescript-eslint/parser from 5.59.8 to 5.59.9
([#226](#226))
([be33aac](be33aac))
* **deps-dev:** Bump eslint from 8.41.0 to 8.42.0
([#225](#225))
([f4733fc](f4733fc))
* **deps-dev:** Bump lint-staged from 13.2.2 to 13.2.3
([#268](#268))
([2897292](2897292))
* **deps-dev:** Bump ts-loader from 9.4.3 to 9.4.4
([#271](#271))
([5a217aa](5a217aa))
* **deps:** Bump @nestjs/config from 2.3.2 to 2.3.3
([#231](#231))
([9e021e1](9e021e1))
* **deps:** Bump @nestjs/passport from 9.0.3 to 10.0.0
([#247](#247))
([7848b52](7848b52))
* **deps:** Bump @nestjs/swagger from 7.0.10 to 7.0.11
([#272](#272))
([ea1ced8](ea1ced8))
* **deps:** Bump @nestjs/swagger from 7.0.3 to 7.0.4
([#259](#259))
([7c53732](7c53732))
* **deps:** Bump @nestjs/swagger from 7.0.6 to 7.0.10
([#267](#267))
([58b8eb1](58b8eb1))
* **deps:** Bump @nestjs/terminus from 9.2.2 to 10.0.1
([#252](#252))
([5edcdde](5edcdde))
* **deps:** Bump dotenv from 16.0.3 to 16.1.1
([#216](#216))
([48f8729](48f8729))
* **deps:** Bump dotenv from 16.1.2 to 16.1.3
([#221](#221))
([0c9c3c8](0c9c3c8))
* **deps:** Bump dotenv from 16.1.3 to 16.1.4
([#224](#224))
([4dc4ba8](4dc4ba8))
* **deps:** Bump tslib from 2.5.2 to 2.5.3
([#223](#223))
([ac676c4](ac676c4))
* **deps:** Bump typeorm from 0.3.16 to 0.3.17
([#257](#257))
([1620abe](1620abe))
* **deps:** Bump typeorm-extension from 2.8.0 to 2.8.1
([#213](#213))
([1a410cc](1a410cc))
* **deps:** Bump typescript from 5.0.4 to 5.1.3
([#222](#222))
([d4fdc70](d4fdc70))
* **deps:** Bump typescript from 5.1.3 to 5.1.5
([#269](#269))
([84c8dfd](84c8dfd))
* **deps:** Bump typescript from 5.1.5 to 5.1.6
([#273](#273))
([278035a](278035a))
* **deps:** update all
([#253](#253))
([7e2317c](7e2317c))
* **deps:** update all
([#264](#264))
([b56b92c](b56b92c))
* **deps:** update all
([#276](#276))
([2fe3c92](2fe3c92))
* **deps:** update commitlint monorepo to v17.6.6
([#263](#263))
([21ebc15](21ebc15))
* **deps:** update dependency @nestjs/cli to v10
([#240](#240))
([f11f43a](f11f43a))
* **deps:** update dependency @nestjs/cli to v10.0.2
([#248](#248))
([d8ed8d6](d8ed8d6))
* **deps:** update dependency @nestjs/cli to v10.1.1
([#278](#278))
([4f7f2af](4f7f2af))
* **deps:** update dependency sort-package-json to v2.5.0
([#277](#277))
([944f91c](944f91c))
* **deps:** update typescript-eslint monorepo to v5.60.0
([#254](#254))
([12b3348](12b3348))
* **deps:** update typescript-eslint monorepo to v5.60.1
([#265](#265))
([594de1b](594de1b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avaitonis avaitonis avaitonis approved these changes

@IgnatG IgnatG IgnatG approved these changes

Assignees

@abhi-markan abhi-markan

Labels
Infrastructure Infrastructure or IaC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhi-markan @avaitonis @IgnatG