Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Restructure - merge? #8

Open
der opened this issue Jul 28, 2016 · 1 comment
Open

UI Restructure - merge? #8

der opened this issue Jul 28, 2016 · 1 comment

Comments

@der
Copy link
Contributor

der commented Jul 28, 2016

I've implemented some UI simplifications in response to various user feedback. This is aimed at making routine registry admin (create a register, upload or patch a set of entries using e.g. a CSV) easier for non-experts. For example, by hiding some more advanced features in the "advanced" menu and by packaging standard options as drop downs/radio buttons.

As part of this I've restructured the velocity templates area to improve structuring and make them easier to maintain.

I've also restructured how the main CSS file is generated to make it easier to customize the look and feel. This is based on using sass to generate a customized bootstrap and add core registry styles. In doing so I've updated the default look and feel to be more compatible with GOV.UK styling.

This forms the basis for new deployments of the UK Environment and Location registries (e.g. see http://environment.data.gov.uk/registry - though without a login the UI changes other than look&feel aren't visible).

This is all currently in branch ui-restructure.

Now that this work has completed and there are a couple of instances in production I'd like to merge this into master. I know that @marqh at least uses registry-config-base as an upstream so that a merge would mean your next rebase might be a little different from normal. So I'll hold off the merge for a short time until we have a chance to confirm it is acceptable.

@der
Copy link
Contributor Author

der commented Aug 3, 2016

One item to consider. The CSS restructuring currently builds a customized bootstrap.css from SASS - injecting registry specific CSS elements. May need to consider whether that can/should be split into separate elements (customized bootstrap.css, registry.css) to allow replacement of just the bootstrap part. If the the answer is "yes" then this could be a separate issue and need not itself hold off the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant