-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SGPT support #1590
Comments
Yes, I would be happy to merge such a PR |
@Muennighoff @nreimers
|
There has been no new version released since the merge, so you need to install from source via |
@nreimers Awesome work on this project. Would it be possible to make a release now that this is merged into the main branch now? It would be much appreciated to not have to install this from Git all the time. Perhaps there is some ongoing effort that has delayed a new release? |
@nreimers I pip installed the newest version by using the commands shown below, and still having the same issue @Muennighoff mentioned earlier. I was trying code
|
Hmm can you try what's explained here: Muennighoff/sgpt#14 (comment) |
The code in |
@Muennighoff, I got stuck on same issue. I fixed it by running your solution.
Thank you! |
Hello! I intend to publish a new release soon, then this should be fully resolved without the workaround. Until then, feel free to use the workaround! I'll close this, as SGPT support has been added.
|
@tomaarsen still getting the error even after the latest update, any fix? |
Hello @zubairahmed-ai, (Related: https://huggingface.co/mixedbread-ai/mxbai-embed-large-v1/discussions/7) I'm unable to reproduce this with the latest version. Are you confident that you're using the latest version? What happens if you run this code? from sentence_transformers import SentenceTransformer, __version__ as sentence_transformers_version
print(sentence_transformers_version)
model = SentenceTransformer("mixedbread-ai/mxbai-embed-large-v1")
embeddings = model.encode(["The weather is nice", "It is sunny today"])
print(embeddings.shape) A possibility is that your updated sentence transformers is installed in a different Python installation than what you use to run your LanceDB code.
|
This was indeed the case, sorry for not updating, thanks for looking into it |
No worries! I'm glad you got it resolved :) |
Hey, would you merge a PR adding support for SGPT? I think I would just need to add a pooling method to
Pooling.py
.Currently, using SGPT via the HF Inference API fails with
__init__() got an unexpected keyword argument 'pooling_mode_weightedmean_tokens'
, because of the missing pooling method. I could also add it as a separate library to the HF Inf API, but I think it'd be much simpler to add the pooling method to this library.The text was updated successfully, but these errors were encountered: