BXC-4688 add processingJobs field to list projects cmd #113
Conversation
| ObjectNode velocicropterStatus = mapper.createObjectNode(); | ||
| if (Files.exists(project.getProjectPath().resolve("processing/results/velocicroptor/job_completed"))) { | ||
| velocicropterStatus.put(STATUS, COMPLETED); | ||
| processingJobs.set("velocicropter", velocicropterStatus); |
There was a problem hiding this comment.
should be velocicroptor rather than velocicropter. Maybe we need a constant for it somewhere since it's a mouthful, maybe a JOB_NAME constant in VelocicroptorRemoteJob that we should also use here https://github.com/UNC-Libraries/chompb/blob/main/src/main/java/edu/unc/lib/boxc/migration/cdm/ProcessSourceFilesCommand.java#L68
|
|
||
| // velocicropter report status | ||
| ObjectNode velocicropterStatus = mapper.createObjectNode(); | ||
| if (Files.exists(project.getProjectPath().resolve("processing/results/velocicroptor/job_completed"))) { |
There was a problem hiding this comment.
we should use this constant for where to find the velocicroptor results, to make it easier to keep things synced:
https://github.com/UNC-Libraries/chompb/blob/main/src/main/java/edu/unc/lib/boxc/migration/cdm/jobs/VelocicroptorRemoteJob.java#L28
you can change it to public
| objectNode.set("projectProperties", projectProperties); | ||
| objectNode.set("processingJobs", processingJobs); |
There was a problem hiding this comment.
might as well make constants for both of these, since all the other top level keys have them
…roptorRemoteJob constants, fix spelling
https://unclibrary.atlassian.net/browse/BXC-4688
Add
processingJobsfield tolist_projectscommand. Each job will have apendingorcompletedstatus. Currently, the only job is velocicropter.