BXC-4768 ignore pdf children #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbpennel
reviewed
Nov 6, 2024
| ResultSet rs = stmt.executeQuery("select " + joinedFields | ||
| + " from " + CdmIndexService.TB_NAME + " order by " + CdmFieldInfo.CDM_ID + " asc"); | ||
| rs.next(); | ||
| assertEquals(17926, rs.getInt(CdmFieldInfo.CDM_ID)); |
There was a problem hiding this comment.
It seems like it isn't actually ignoring the children of the document pdf, since "page 1" is one of them? My impression is we would not want any of the pages that appear in the cpd file to be in the index, or that we would have to ignore those pages somehow in other steps. So it might be that we need to do something like we do for compounds here:
but instead of assigning each child a parent, we delete the child
bbpennel
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://unclibrary.atlassian.net/browse/BXC-4768
Document-PDFand skip over its childrenENTRY_TYPE_FIELD/cdm2bxc_entry_typetodoc-pdf