BXC-4303 Generate list of collection numbers #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and tests, add fieldName option to DestinationMappingOptions
bbpennel
requested changes
Oct 11, 2023
| CdmEnvironmentHelper.DEFAULT_ENV_ID, BxcEnvironmentHelper.DEFAULT_ENV_ID); | ||
| testHelper = new SipServiceHelper(project, tmpFolder); | ||
| service = new ArchivalDestinationsService(); | ||
| indexService = new IndexFilteringService(); |
There was a problem hiding this comment.
Looks like this isn't being used since it passes in testHelper.getIndexService() below
bbpennel
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://unclibrary.atlassian.net/browse/BXC-4303
ArchivalDestinationsServicegenerateCollectionNumbersListmethod: generate unique list of values for provided field nameDestinationMappingOptions