-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG, ENH] Update tutorial and documentation #162
Conversation
Added #only-dark/light to show or hide dark vs bright images according to color mode. Added #border classes to add border on images so it's easier where the image border is.
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
=========================================
Coverage ? 67.84%
=========================================
Files ? 10
Lines ? 650
Branches ? 98
=========================================
Hits ? 441
Misses ? 183
Partials ? 26
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks to @Remi-Gau for opening #142 and warning about an error in the tutorial. The earlier version of the tutorial was tested on a previous version of dcm2niix. See #598 for a comparison of the results based on different releases.
I also improved the documentation by reorganizing how it is displayed in addition to adding a bunch of details such as dark mode!!