Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Endpoint: TimeZones #499

Closed
Tracked by #486 ...
MikeNeilson opened this issue Jan 11, 2024 · 5 comments · Fixed by #703
Closed
Tracked by #486 ...

Update Endpoint: TimeZones #499

MikeNeilson opened this issue Jan 11, 2024 · 5 comments · Fixed by #703
Labels
approved-W192HQ23F0232-task4 Only valid if set by MikeNeilson, DanielO, CharlesG enhancement New feature or request good first issue Good for newcomers priority:medium We care, and will try and get to it soon.

Comments

@MikeNeilson
Copy link
Contributor

Add deprecated header

Implement new style if not already done.

Task approval is for either doing, or PR, assign to self if planning to do the work.

@MikeNeilson MikeNeilson added enhancement New feature or request good first issue Good for newcomers priority:medium We care, and will try and get to it soon. approved-W192HQ23F0232-task4 Only valid if set by MikeNeilson, DanielO, CharlesG labels Jan 11, 2024
@RyanM-RMA RyanM-RMA assigned RyanM-RMA and unassigned RyanM-RMA Jun 5, 2024
@RyanM-RMA
Copy link
Collaborator

Hi Mike, what do you mean by "Implement new style if not already done"? Is that using the Formats.parseHeaderAndQueryParam while passing in the query param and header? Just wanting to make sure, cause that's what I understood and estimated for.

@MikeNeilson
Copy link
Contributor Author

Oh, doing the rendering of data in Java instead of the database doing it.... really should've written it that way the first time.

Also, the deprecated header would be for the old database format, not the endpoint itself.

@RyanM-RMA
Copy link
Collaborator

Will that require a DTO?

@MikeNeilson
Copy link
Contributor Author

... Maybe, It's a pretty constrained list so it doesn't really need to be paginated. The Java TimeZone class might be sufficient.

@RyanM-RMA
Copy link
Collaborator

It's the same for Units and Parameters btw. Those three don't have DTO's, and they're using the db for formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-W192HQ23F0232-task4 Only valid if set by MikeNeilson, DanielO, CharlesG enhancement New feature or request good first issue Good for newcomers priority:medium We care, and will try and get to it soon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants