rapidjson internal assertion failure when using a locale that uses "," as decimal seperator

[nebw]

Cereal uses an old version of rapidjson which may use "," as a decimal seperator (see Tencent/rapidjson#72). This was fixed in the rapidjson commit Tencent/rapidjson@adb3974 .

Is it possible to update to a newer rapidjson version or to merge the specific changes in the mentioned commit?

[AzothAmmo]

Updating RapidJSON is on our TODO list (see #82, which includes some heavier work too) but if people are running into issues we can make updating it more of a priority.

[nebw]

Thanks for the quick reply. In our case, we opted for setting the LC_NUMERIC locale manually on program startup for now. Therefore, we have no immediate need for a fix.

On the other hand, I'd say that this is a very urgent problem as it effectively breaks json support for all use cases where any user might have a non-english locale.

[AzothAmmo]

Added a new branch for updating rapidjson: https://github.com/USCiLab/cereal/tree/new_rapidjson, see 1934a32