Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation of sharp cut off of organic aerosols in ELMO #212

Closed
bnmurphy opened this issue Feb 8, 2024 · 1 comment
Closed

Calculation of sharp cut off of organic aerosols in ELMO #212

bnmurphy opened this issue Feb 8, 2024 · 1 comment
Labels

Comments

@bnmurphy
Copy link
Contributor

bnmurphy commented Feb 8, 2024

Description
The calculation of organic aerosol from the ELMO module in v5.4 has slight errors for sharp cut offs. The calculation of total PMF organic aerosol is correct.

Scope and Impact
This effects calculations of organic aerosol for PM2.5 and PM1 with the hard size cutoff.

Solution
A permanent solution will be posted via Pull Request to this repository. Temporarily, users can fix the issue in ELMO_PROC.F:
Change

Line 2707: CALL GET_AERO_INLET( IPM1, IM, IWET, FRAC( IMODE ) )
Line 2723: CALL GET_AERO_INLET( IPM1, IM, IWET, FRAC( IMODE ) )
Line 2736: CALL GET_AERO_INLET( IPM25, IM, IWET, FRAC( IMODE ) )
Line 2752: CALL GET_AERO_INLET( IPM25, IM, IWET, FRAC( IMODE ) )

To

Line 2707: CALL GET_AERO_INLET( IPM1, IMODE, IWET, FRAC( IMODE ) )
Line 2723: CALL GET_AERO_INLET( IPM1, IMODE, IWET, FRAC( IMODE ) )
Line 2736: CALL GET_AERO_INLET( IPM25, IMODE, IWET, FRAC( IMODE ) )
Line 2752: CALL GET_AERO_INLET( IPM25, IMODE, IWET, FRAC( IMODE ) )
@bnmurphy bnmurphy added the bug label Feb 8, 2024
@kmfoley kmfoley changed the title Calculation of PM2.5 in ELMO Calculation of sharp cut off of organic aerosols in ELMO May 24, 2024
@kmfoley kmfoley closed this as completed May 28, 2024
@kmfoley kmfoley reopened this May 28, 2024
@bnmurphy bnmurphy reopened this Jul 25, 2024
@bnmurphy
Copy link
Contributor Author

Addressed in PR #218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants