cnetbin2pvl not printing some values

[ascbot]

---

Author Name: Guy McArthur (Guy McArthur)

---

Sometimes, there is a matched point with a LineResidual but not a SampleResidual (possibly it was 0.0).
PS Can't attach a binary control net file.

[ascbot]

---

Original Redmine Comment
Author Name: Makayla Shepherd (Makayla Shepherd)
Original Date: 2018-11-06T21:08:45Z

---

Can you describe the circumstances where it doesn't print out?

[ascbot]

---

Original Redmine Comment
Author Name: Guy McArthur (Guy McArthur)
Original Date: 2018-11-06T23:12:56Z

---

Here's an example, from a the control net generated by hijitreg:

  Object = ControlPoint
    PointType   = Free
    PointId     = "Row 12 Column 5"
    ChooserName = hijitreg
    DateTime    = 2018-11-05T13:38:46

    Group = ControlMeasure
      SerialNumber  = MRO/HIRISE/847420242:06854/RED4/2
      MeasureType   = RegisteredPixel
      ChooserName   = hijitreg
      DateTime      = 2018-11-05T13:38:46
      Sample        = 935.0
      Line          = 1252.9986857831
      LineResidual  = -2.9986857830579 <pixels>
      GoodnessOfFit = 0.9299503231071
    End_Group

    Group = ControlMeasure
      SerialNumber = MRO/HIRISE/847420242:06854/IR10/2
      MeasureType  = Candidate
      ChooserName  = hijitreg
      DateTime     = 2018-11-05T13:38:46
      Sample       = 935.0
      Line         = 1250.0
      Reference    = True
    End_Group
  End_Object

[ascbot]

---

Original Redmine Comment
Author Name: Jesse Mapel (Jesse Mapel)
Original Date: 2018-11-26T15:44:32Z

---

Hi guy,

It looks like you're spot on about the sample residual being 0. There is a check for 0 residual before writing out the residual.

For future developer reference, here's the line in question https://github.com/jessemapel/ISIS3/blob/dev/isis/src/control/objs/ControlNetVersioner/ControlNetVersioner.cpp#L504

• Jesse Mapel

[jessemapel]

We should either document this behavior or change it to always output the residuals.

[jlaura]

@acpaquette I am going to close this because I think you fixed it in #3194?