Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can edrget be deprecated? #3313

Closed
krlberry opened this issue May 28, 2019 · 11 comments
Closed

Can edrget be deprecated? #3313

krlberry opened this issue May 28, 2019 · 11 comments
Milestone

Comments

@krlberry
Copy link
Contributor

krlberry commented May 28, 2019

Description
The edrget application doesn't seem to do much more than wget, for example. (Does it offer additional key features?) Can it be deprecated and removed from ISIS or would this break anything internally or externally? Is this functionality still needed as part of ISIS?

See: https://isis.astrogeology.usgs.gov/Application/presentation/Tabbed/edrget/edrget.html

@jlaura
Copy link
Collaborator

jlaura commented Jun 1, 2019

I have labelled this 'maintenance' so that we can consider this in the next maintenance/support sprint. If we have not heard anything back on this issue we should consider what a deprecation warning might look like and how we want to present it. We can also generate and publicize whatever deprecation plan we develop and have a concrete example app where this plan is put into practice.

@kberryUSGS Nice catch on this.

@twilson271828
Copy link
Contributor

edrget was designed to be a more user-friendly version than wget for non-programmers who have a url and want to grab files, or perhaps write a simple bash/python script loop to do it. That's about it. Are there scripts or chron jobs running out in the wild that depend on edrget? Possibly. Should they? Probably not.

@jessemapel
Copy link
Contributor

edrget is causing trouble again. It is intermittently timing out during Jenkins tests.

@ascbot
Copy link
Contributor

ascbot commented Sep 1, 2020

I am a bot that cleans up old issues that do not have activity.

This issue has not received feedback in the last six months. I am going to add the inactive label to
this issue. If this is still a pertinent issue, please add a comment or add an emoji to an existing comment.

I will post again in five months with another reminder and will close this issue on it's birthday unless it has
some activity.

@ascbot ascbot added the inactive Issue that has been inactive for at least 6 months label Sep 1, 2020
@krlberry
Copy link
Contributor Author

krlberry commented Sep 2, 2020

This is still applicable. @jlaura is the next step for this to write up an RFC about potentially deprecating edrget?

@jlaura
Copy link
Collaborator

jlaura commented Sep 2, 2020

Yup - we need to get an RFC written, linking to this issue and then we can see what discussion we get from there.

Also, thanks for reviewing these issues labelled inactive and keeping them on all our radar.

@krlberry krlberry removed the inactive Issue that has been inactive for at least 6 months label Sep 2, 2020
@jlaura
Copy link
Collaborator

jlaura commented Dec 3, 2020

@kberryUSGS Can you get an RFC written for this under the continuous support. I would like to avoid the open-close merry-go-round without action.

@github-actions
Copy link

github-actions bot commented Jun 2, 2021

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label Jun 2, 2021
@rbeyer
Copy link
Contributor

rbeyer commented Jun 2, 2021

I don't think this needs an RFC, which is what has kept this delayed for so long. I think RFCs should only be for significant changes. I do not think that this qualifies.

For now, make edrget emit a warning message when it runs about being deprecated and a warning that it may be removed in ISIS 6.0, and then whenever ISIS 6.0 ticks, axe it. There should be enough time before ISIS 6.0 (although, who knows) for the warning message to reach the one or two people that might still use it (but I'd be surprised if it was that many).

@rbeyer rbeyer removed the inactive Issue that has been inactive for at least 6 months label Jun 2, 2021
@jlaura jlaura added this to the 5.0.1 milestone Jun 2, 2021
@rbeyer rbeyer mentioned this issue Aug 3, 2021
@AustinSanders AustinSanders modified the milestones: 5.0.1, 6.1.0 Aug 5, 2021
@AustinSanders
Copy link
Contributor

There seems to be a general consensus that we should deprecate edrget, and that there is no need for an RFC. In order to close this issue, we should

  1. Place a deprecation warning in edrget
  2. Add a section to the changelog.md that tracks deprecated functionality.

@jessemapel
Copy link
Contributor

We also need to add a step to the release process to remove deprecated functionality when we do a major version release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants