Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library version #3365

Closed
oleg-alexandrov opened this issue Aug 2, 2019 · 5 comments
Closed

Library version #3365

oleg-alexandrov opened this issue Aug 2, 2019 · 5 comments
Labels
bug Something isn't working build Issue related to building ISIS

Comments

@oleg-alexandrov
Copy link
Contributor

I see that ISIS is now at version 3.8, but the output built library still says 3.6: https://github.com/USGS-Astrogeology/ISIS3/blob/ef390cc4510b0c7ef677604f756372edf363c0c5/isis/CMakeLists.txt#L391

This could be on purpose. I just was surprised that after I built the freshest ISIS the library number was still the same.

@jlaura
Copy link
Collaborator

jlaura commented Aug 2, 2019

This is a bug. @ALL Can we get this slotted next week as well and then get the release docs updated.

@jessemapel jessemapel added bug Something isn't working build Issue related to building ISIS labels Aug 2, 2019
@SgStapleton SgStapleton self-assigned this Aug 14, 2019
@SgStapleton
Copy link
Contributor

So, it looks like these are rm commands... This is clearly not correct, but I am not sure these lines would be responsible for the creation of the libisis3.6(.0).so files in the first place.

@oleg-alexandrov
Copy link
Contributor Author

@oleg-alexandrov
Copy link
Contributor Author

Now at isis 4.1.0, but the library is still named libisis3.6.0.so. There is also a sym link saying libisis3.so. I guess version 3 has staying power. :)

@jlaura
Copy link
Collaborator

jlaura commented Sep 1, 2020

@Kelvinrr It looks like #3992 closed this. I am going to close. Please reopen if this is still an issue.

@jlaura jlaura closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Issue related to building ISIS
Projects
None yet
Development

No branches or pull requests

4 participants