Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolarLon should be computed from Table if cube is spiceinited. #3703

Closed
Kelvinrr opened this issue Feb 21, 2020 · 3 comments · Fixed by #4418
Closed

SolarLon should be computed from Table if cube is spiceinited. #3703

Kelvinrr opened this issue Feb 21, 2020 · 3 comments · Fixed by #4418
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Feb 21, 2020

ISIS version(s) affected: 4.X.X

Description

Spice::computeSolarLon by default always computes solar lon and appends it the cube label from Spice kernels. This should use the tables if present. This is an issue when creating tables from ISDs instead of going through the spiceinit process.

How to reproduce

Run Campt on a cube that doesn't have the solor lon key present and you'll get a tiny negative number in place of real solor lon.

Possible Solution

The code already exists in Spice::computeSolarLon it just needs the if statement changed to include if (m_usingAle || !m_usingNaif). This will create a subtle difference in SolorLon value so tests will need to be updated.

Additional context

@jlaura
Copy link
Collaborator

jlaura commented Mar 10, 2020

@Kelvinrr Is this a bug or an enhancement?

@Kelvinrr Kelvinrr added the bug Something isn't working label Mar 10, 2020
@Kelvinrr
Copy link
Collaborator Author

Bug, as this causes SolarLon to not be computed correctly when the cube is spiceinited using ALE.

@ascbot
Copy link
Contributor

ascbot commented Sep 24, 2020

I am a bot that cleans up old issues that do not have activity.

This issue has not received feedback in the last six months. I am going to add the inactive label to
this issue. If this is still a pertinent issue, please add a comment or add an emoji to an existing comment.

I will post again in five months with another reminder and will close this issue on it's birthday unless it has
some activity.

@ascbot ascbot added the inactive Issue that has been inactive for at least 6 months label Sep 24, 2020
@acpaquette acpaquette removed the inactive Issue that has been inactive for at least 6 months label Apr 10, 2021
@acpaquette acpaquette added this to the 5.0.1 milestone Apr 10, 2021
@amystamile-usgs amystamile-usgs self-assigned this Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants