Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map2cam running out of file descriptors #3841

Closed
scsides opened this issue Apr 10, 2020 · 2 comments
Closed

map2cam running out of file descriptors #3841

scsides opened this issue Apr 10, 2020 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers Products Issues which are impacting the products group

Comments

@scsides
Copy link
Contributor

scsides commented Apr 10, 2020

ISIS version(s) affected: 4.0.1 and most likely nearly any recent version

Description
map2cam run in batch mode with 2000 images in the batch file fails around file 1018:

map2cam from= themosmap/mc02_diacria_dir_final.cub to=themosmap/$1_mapIR match=$1 -batch=cub.lis -onerror=continue -errli=mapthem.err

LOTS OF NOT SHOWN LINES WHERE map2cam WAS SUCCEEDING


map2cam from=themosmap/mc02_diacria_dir_final.cub to=themosmap/H0682_0003_SR2.IMG.cub_mapIR match=H0682_0003_SR2.IMG.cub
I/O ERROR Unable to open [H0682_0003_SR2.IMG.cub].
map2cam from=themosmap/mc02_diacria_dir_final.cub to=themosmap/H0682_0004_SR2.IMG.cub_mapIR match=H0682_0004_SR2.IMG.cub
terminate called after throwing an instance of 'Isis::IException'
what(): I/O ERROR Unable to open [/scratch/repos/hrsc-ssides/build/appdata/templates/labels/CubeFormatTemplate.pft].
Aborted (core dumped)

It looks like map2cam is not closing a file inside the batch loop.

ulimit -n shows an open file limit of 1024.

Running lsof while the batch is running shows that all the MATCH files remain open until the crash.

How to reproduce
See description

Possible Solution
Close the MATCH file when the ISIS main returns

Additional context

@scsides scsides added enhancement New feature or request good first issue Good for newcomers and removed enhancement New feature or request labels Apr 10, 2020
@scsides scsides added the bug Something isn't working label Apr 11, 2020
@jessemapel
Copy link
Contributor

I'm curious if this exist prior to #3757. The match cube is a global variable but it should get closed during the endProcess call.

@jlaura jlaura added the Products Issues which are impacting the products group label Apr 28, 2020
@scsides scsides closed this as completed Jun 8, 2020
@scsides
Copy link
Contributor Author

scsides commented Jun 8, 2020

PR to fix has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Products Issues which are impacting the products group
Projects
None yet
Development

No branches or pull requests

3 participants