Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats crashes in batch mode after 1018 lines #3842

Closed
scsides opened this issue Apr 11, 2020 · 2 comments
Closed

stats crashes in batch mode after 1018 lines #3842

scsides opened this issue Apr 11, 2020 · 2 comments
Assignees
@scsides
Labels
bug Something isn't working good first issue Good for newcomers Products Issues which are impacting the products group

Comments

@scsides
Copy link
Contributor

scsides commented Apr 11, 2020

ISIS version(s) affected: 4.1.0_RC1

Description
stats fails with unable to open the FROM cube after 1018 lines of batch mode. lsof shows the input cubes are not being closed after each loop of the batch file processing.

See #3841 for a similar problem

How to reproduce
Run ulimit -n to see what your open file limit is
Run stats with -batch=some_file with more lines than your limit of open files

Possible Solution
Close all open files before returning

Additional context
@scsides scsides added bug Something isn't working good first issue Good for newcomers labels Apr 11, 2020
@jessemapel
Copy link
Contributor

stats has a memory leak at https://github.com/USGS-Astrogeology/ISIS3/blob/dev/isis/src/base/apps/stats/stats.cpp#L26

It doesn't ever delete the cube object.

@jlaura jlaura added the Products Issues which are impacting the products group label Apr 28, 2020
@scsides scsides self-assigned this Jun 1, 2020
@scsides
Copy link
Contributor Author

scsides commented Jun 8, 2020

Unable to repeate

@scsides scsides closed this as completed Jun 8, 2020
@jessemapel jessemapel mentioned this issue Jun 8, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scsides scsides

Labels
bug Something isn't working good first issue Good for newcomers Products Issues which are impacting the products group
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlaura @scsides @jessemapel