Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spiceinit not creating cube history entry on MacOS #4040

Closed
rvwagner opened this issue Sep 28, 2020 · 2 comments · Fixed by #4218
Closed

Spiceinit not creating cube history entry on MacOS #4040

rvwagner opened this issue Sep 28, 2020 · 2 comments · Fixed by #4218
Assignees
Labels
bug Something isn't working Missions Issues which are a priority for missions

Comments

@rvwagner
Copy link

ISIS version(s) affected: 4.2.0 (version number manually edited to be 3.420.0 to make web SPICE happy), 3.10.1 on MacOS 10.14.6.

Description
spiceinit isn't putting an entry into the cube's history on the MacOS versions I've looked at. Linux versions 3.9.1, 4.1.0 and 4.2.0_RC1 do put in history entries (both with and without web=true specified for 3.9.1, the later versions do not use web=true).

Other ISIS programs can put in history entries on the same cube file (editlab, lrowaccal tested).

Not terribly critical, but weird.

How to reproduce

wget http://pds.lroc.asu.edu/data/LRO-L-LROC-2-EDR-V1.0/LROLRC_0027/DATA/ESM2/2016163/WAC/M1220245217CE.IMG
lrowac2isis from=M1220245217CE.IMG to=M1220245217CE
spiceinit from=M1220245217CE.vis.even.cub web=true
cathist from= M1220245217CE.vis.even.cub
@jlaura jlaura added the Missions Issues which are a priority for missions label Sep 30, 2020
@jessemapel jessemapel added this to the 4.3.1 milestone Dec 14, 2020
@jessemapel jessemapel added the bug Something isn't working label Dec 14, 2020
@jessemapel
Copy link
Contributor

This is probably due to the spiceinit app conversion not properly adding a history entry. For reference here's the old code: https://github.com/USGS-Astrogeology/ISIS3/blob/53af27e53c06fb38d7cadcfc1b5754c1be3baf45/isis/src/base/apps/spiceinit/main.cpp

@jessemapel jessemapel removed this from the 4.3.1 milestone Dec 15, 2020
@kaitlyndlee kaitlyndlee self-assigned this Dec 21, 2020
@kaitlyndlee
Copy link
Contributor

When I run spiceinit without web=true, I get a history entry on both mac and linux, but when I run with web=true, I do not get a history entry on both. Is this the same behavior you are seeing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Missions Issues which are a priority for missions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants