Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activate scripts written by isisVarInit.py should always have absolute paths #4274

Closed
rbeyer opened this issue Feb 7, 2021 · 0 comments · Fixed by #4275
Closed

activate scripts written by isisVarInit.py should always have absolute paths #4274

rbeyer opened this issue Feb 7, 2021 · 0 comments · Fixed by #4275
Labels
bug Something isn't working installation

Comments

@rbeyer
Copy link
Contributor

rbeyer commented Feb 7, 2021

ISIS version(s) affected: 4.all

Description
If you mistakenly provide a relative path to any of the optional arguments to isisVarInit.py, those relative paths will be written into the generated activation scripts. This results in unexpected behavior, as the various ISIS environment variables should be fully-resolved, absolute paths, not relative ones.

How to reproduce

cd $HOME
python $CONDA_PREFIX/scripts/isisVarInit.py -d foo

The resulting activation scripts will have ISISDATA set to just the bare value of foo instead of /absolute/path/to/$HOME/foo.

Possible Solution
Fully resolve the provided paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working installation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants