Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relevant comment dropped from image label #4442

Closed
lwellerastro opened this issue May 7, 2021 · 7 comments · Fixed by #4496
Closed

Relevant comment dropped from image label #4442

lwellerastro opened this issue May 7, 2021 · 7 comments · Fixed by #4496
Assignees
Labels
bug Something isn't working Products Issues which are impacting the products group

Comments

@lwellerastro
Copy link
Contributor

ISIS version(s) affected: isis5.0.0

Description
When an image is updated by jigsaw a comment is added to the image label specifying when the image was updated, typically right before the InstrumentPointing and InstrumentPosition Objects.

For example:
# Jigged = 2021-05-07T11:06:11

The comment no longer appears in the image label of a jigsaw updated image as of isis5.0.0. This is the only difference between the labels of an image updated via isis4.4.0 and isis5.0.0.

This comment has been included in our labels for at least over 10 years. I use it extensively to determine if and when my images have been updated, particularly when looking at large volume of data.

How to reproduce
Run jigsaw setting update=true in a prior version and the latest version. Compare labels.

See /work/users/lweller/Isis3Tests/Jigsaw/Label/ for catlab ouput and updated image from isis4.4.0 vs isis5.0.0.
See /work/users/lweller/Isis3Tests/Jigsaw/Label/Network/ for a small network and jigsaw command for updating if you need test data.

Possible Solution
Recover the lost comment!

Additional context
The same problem occurs for images updated by deltack

# deltackDirectAdjusted = 2021-05-07T11:28:45

It's possible there is a similar issue for qtie updated images, but I have not checked this.

@lwellerastro lwellerastro added the Products Issues which are impacting the products group label May 7, 2021
@jessemapel jessemapel added the bug Something isn't working label May 7, 2021
@jessemapel
Copy link
Contributor

jessemapel commented May 7, 2021

This is a bug, when we moved to the new Table logic, we only copy over keywords to the BLOB label and didn't add logic to copy over comments. Should be a simple fix.

@scsides
Copy link
Contributor

scsides commented May 14, 2021

NOTE: ISIS PVL attaches comments to keywords or groups or objects (what ever immediately follows them). At one time reading a keyword and writing it should have copied the comment too.

@jessemapel
Copy link
Contributor

jigsaw attaches the jigged comment directly to the Table's Label, not any of the keywords. So, copying over the keywords doesn't catch these comments.

@lwellerastro
Copy link
Contributor Author

this is still a problem under 5.0.1

@jessemapel
Copy link
Contributor

#4496 also missed the cherry-pick over to 5.0.1 same as #4375. I'm going to open a new issue to collect these so that we have a full record of what needs to be moved over for 5.0.2.

@lwellerastro
Copy link
Contributor Author

@jessemapel wondering what version of ISIS this and the other missed posts will be available. I haven't seen any announcements for 5.0.2 and don't see it listed under the local conda envs. Are we going straight to 6.0?

@jessemapel
Copy link
Contributor

I've put out a 5.0.2 build with all of the bug fixes in it. It's already available internally if you want to try it. The release announcement will go out today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Products Issues which are impacting the products group
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants